Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup frontend dependencies and update Kubernetes dependencies #6688

Merged
merged 12 commits into from
Jan 27, 2022

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Jan 13, 2022

Closes #6634.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #6688 (7cf55e5) into master (4ab436f) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6688      +/-   ##
==========================================
- Coverage   41.89%   41.86%   -0.04%     
==========================================
  Files          44       44              
  Lines        1234     1235       +1     
  Branches      178      178              
==========================================
  Hits          517      517              
- Misses        678      679       +1     
  Partials       39       39              

@maciaszczykm maciaszczykm changed the title Cleanup dependencies [WIP] Cleanup dependencies Jan 13, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2022
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@shu-mutou
Copy link
Contributor

shu-mutou commented Jan 14, 2022

I created #6690 as a continuation of yesterday.
I ran the checks locally for each commit, so it probably works.
Now, it's the end of the day, so I'm leaving without seeing the CI results.
I'm preciated you would concentrate to remove unused packages. See you next week!

@k8s-ci-robot k8s-ci-robot added language/ja Updates or issues for Japanese translations. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 27, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 27, 2022
@maciaszczykm maciaszczykm changed the base branch from master to gh-pages January 27, 2022 10:04
@maciaszczykm maciaszczykm changed the base branch from gh-pages to master January 27, 2022 10:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 27, 2022
@maciaszczykm maciaszczykm changed the title [WIP] Cleanup dependencies Cleanup dependencies Jan 27, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2022
@maciaszczykm
Copy link
Member Author

@shu-mutou @floreks PTAL

@maciaszczykm maciaszczykm changed the title Cleanup dependencies Cleanup frontend dependencies and update Kubernetes dependencies Jan 27, 2022
@maciaszczykm
Copy link
Member Author

I've also updated k8s dependencies.

@floreks
Copy link
Member

floreks commented Jan 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e591ea5 into kubernetes:master Jan 27, 2022
@maciaszczykm maciaszczykm deleted the dependency-cleanup branch January 27, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Updates or issues for Japanese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused dependencies from package.json
4 participants