-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nfd-gc on NodeResourceTopology objects #1586
Comments
/assign @ozhuraki |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What would you like to be added:
We could possibly improve the behavior of nfd-gc by removing stale NRT objects (whose creator pod does not exist anymore). The
ownerReference
field shouldn't be used as that creates warnings (see k8s garbage-collection). We could use an nfd-specific annotation (likenfd.node.kubernetes.io/owner-pod: <namespace>/<pod-uuid>
). The nfd-gc would delete the object if the pod doesn't exist. Possibly acting only if<namespace>
is the same where nfd-gc itself is running (so that it doesn't need cluster-wide access to get/list all pods in all namespaces).This would be a separate improvement in addiotion to #1551 (which didn't play out quite as I initially thought).
Why is this needed:
Better management of NRT objects. Potentially fewer stale objects in the cluster.
The text was updated successfully, but these errors were encountered: