Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner reference for NRT objects created by topology-updater #1551

Closed
marquiz opened this issue Jan 17, 2024 · 2 comments · Fixed by #1602
Closed

Add owner reference for NRT objects created by topology-updater #1551

marquiz opened this issue Jan 17, 2024 · 2 comments · Fixed by #1602
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Jan 17, 2024

What would you like to be added:

We previously (in v0.15) enabled owner references in NodeFeature objects created by nfd-worker. We could do the same with nfd-topology-updater and NodeResourceTopology objects. Setting the owner reference enables automatic garbage-collection of orphaned NodeResourceTopology objects (i.e. whose owner topology-updater pod has gone) by Kubernetes

Why is this needed:

Automatic garbage-collection of NodeResourceTopology objects e.g. when the nfd-topology-updater is undeployed.

@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 17, 2024
@ozhuraki
Copy link
Contributor

ozhuraki commented Feb 2, 2024

/assign @ozhuraki

@marquiz
Copy link
Contributor Author

marquiz commented Feb 14, 2024

I didn't realize that this doesn't work similarly with cluster-scoped resources. Cluster-scoped objects referencing
namespaced owners do not get GC'd, but create a warning instead (https://kubernetes.io/docs/concepts/architecture/garbage-collection).

We could set the nfd ns in the ownerReference to get a bit better GC behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants