Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial admission #771

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Partial admission #771

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
180c092
[API][Workload] Add `miniCount` for PodSet
trasc May 12, 2023
1ab2955
[util] Add util slice and maps.
trasc May 15, 2023
2ca0d7b
[scheduler] Partial flavors assignment
trasc May 12, 2023
3adba45
[jobframework] Add support for partial admission
trasc May 15, 2023
d3e0ad1
[batch/job] Partial admission
trasc May 17, 2023
2844d17
[partialAdmission] Add feature gate
trasc May 29, 2023
49989ba
[webhook/workload] Validate minCount
trasc Jun 6, 2023
79be7c4
[webhook/workload] Limit the number of variable count podSets
trasc Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[API][Workload] Add miniCount for PodSet
  • Loading branch information
@trasc
trasc committed Jun 7, 2023
commit 180c09268a38ab9a0b93bb06917d08329bab1cab
11 changes: 11 additions & 0 deletions apis/kueue/v1beta1/workload_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,17 @@ type PodSet struct {
// count is the number of pods for the spec.
// +kubebuilder:validation:Minimum=1
Count int32 `json:"count"`

// minCount is the minimum number of pods for the spec acceptable
// if the workload supports partial admission.
//
// If not provided, partial admission for the current PodSet is not
// enabled.
//
// Only one podSet within the workload can use this.
//
// +optional
MinCount *int32 `json:"minCount,omitempty"`
}

// WorkloadStatus defines the observed state of Workload
Expand Down
5 changes: 5 additions & 0 deletions apis/kueue/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ spec:
format: int32
minimum: 1
type: integer
minCount:
description: "minCount is the minimum number of pods for the
spec acceptable if the workload supports partial admission.
\n If not provided, partial admission for the current PodSet
is not enabled. \n Only one podSet within the workload can
use this."
format: int32
type: integer
name:
description: name is the PodSet name.
type: string
Expand Down
8 changes: 8 additions & 0 deletions config/components/crd/bases/kueue.x-k8s.io_workloads.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ spec:
format: int32
minimum: 1
type: integer
minCount:
description: "minCount is the minimum number of pods for the
spec acceptable if the workload supports partial admission.
\n If not provided, partial admission for the current PodSet
is not enabled. \n Only one podSet within the workload can
use this."
format: int32
type: integer
name:
description: name is the PodSet name.
type: string
Expand Down