-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial admission #771
Partial admission #771
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
7297247
to
50aae9b
Compare
/cc @alculquicondor |
I queued this PR to my tomorrow review queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this implementation covers all use cases. See my comment in the flavor assigner.
7e0c655
to
bbea05b
Compare
I didn't review scheduler, preemption or flavor_assigner yet. I hope we can merge #806 first |
5e4848d
to
d84fda9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but I'm looking for opportunities to simplify.
I think we might need to revert the annotation. Could you explore this possibility in a preparatory PR?
bbb102b
to
9d0a2be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Just final nits
Please adjust the release note to indicate that this is specific to Job.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for partial workload admission.
Which issue(s) this PR fixes:
Fixes #420
Special notes for your reviewer:
Does this PR introduce a user-facing change?