-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build pipeline image even on schedules and master #9648
Conversation
Hi @luksi1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luksi1 Thanks, I was going to fix this one 🙇
🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, luksi1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@luksi1 Thank you very much |
/ok-to-test |
No need to rebase this one, I'll force merge it |
/kind bug
What this PR does / why we need it:
It fixes fails on scheduled pipelines and master branch pipelines, as the pipeline image is needed for both of these
Fixes #9606
See comment: #9606 (comment)
Special notes for your reviewer:
@yankay This should problems with the pipeline failing on the master branch
Does this PR introduce a user-facing change?:
NONE