Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a pipeline image and eliminates "pipeline bloat" from the Kubespray image #9606

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

luksi1
Copy link
Contributor

@luksi1 luksi1 commented Dec 22, 2022

/kind cleanup

What this PR does / why we need it:

Downstream users of Kubespray should not have all of the bloat from pipeline requirements in the released Docker image

Which issue(s) this PR fixes:
Fixes #9411

Does this PR introduce a user-facing change?:
None

- Creates a separate image for pipeline tests
- Reduces the size of the released image

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @luksi1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2022
@luksi1 luksi1 force-pushed the issue_9411 branch 14 times, most recently from 5a5b95b to 0850666 Compare December 22, 2022 19:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2022
@luksi1 luksi1 marked this pull request as ready for review December 22, 2022 22:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2022
@luksi1 luksi1 mentioned this pull request Dec 22, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luksi1 Thank you, I like the idea of a gitlab pipeline image in the gitlab pipeline CR
I've added a cleanup rule not to bloat the CR indeed

The only downside I see here is the 10+ minutes added to every pipeline, but that don't seem like a big issue to me.

@oomichi WDYT ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, luksi1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2022
@yankay
Copy link
Member

yankay commented Jan 9, 2023

Thanks @luksi1
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit a98ab40 into kubernetes-sigs:master Jan 9, 2023
@yankay
Copy link
Member

yankay commented Jan 9, 2023

HI @luksi1 , the PR causes the CI broken :
image

would you please fix it ? :-)

@luksi1
Copy link
Contributor Author

luksi1 commented Jan 9, 2023

Odd. These tests passed in the PR. I'll take a look at it a bit later today.

@luksi1
Copy link
Contributor Author

luksi1 commented Jan 9, 2023

@yankay Can you please take a look at #9648? I believe this should fix the issue.

enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@tu1h tu1h mentioned this pull request Jan 28, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too large docker image
4 participants