Remove runtime-config from kubeadm if empty #6311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
/approve |
k8s-ci-robot
added
the
approved
|
maybe the default in checking with defined although the default is always defined feels wrong to me. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Indeed, I've aligned with other params like |
|
I think it's cleaner this way |
k8s-ci-robot
added
the
lgtm
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Jun 30, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: (22 commits) Remove runtime-config from kubeadm if empty (kubernetes-sigs#6311) Update deprecated api (kubernetes-sigs#6245) Update kube-router to 1.0.0 (kubernetes-sigs#6211) Fix kubelet cgroup driver detection for crio (kubernetes-sigs#6331) Update hashes and set default version to 1.18.5 (kubernetes-sigs#6335) Change MetalLB to one of addons (kubernetes-sigs#6238) Update calico to 1.15.0 + minor update to kube-ovn/weave (kubernetes-sigs#6306) Add .editorconfig file (kubernetes-sigs#6307) Use NetworkManager to manage resolv.conf in FedoraCoreOS (kubernetes-sigs#6291) Add USE_REAL_HOSTNAME to inventory.py (kubernetes-sigs#6293) Cleanup OpenStack network things (kubernetes-sigs#6283) Add support for dns_etchosts (kubernetes-sigs#6236) kube_encryption_resources must be output as yaml (kubernetes-sigs#6309) Gather ansible_default_ipv4 for specific groups (kubernetes-sigs#6318) added azure_cloud parameter to Azure's cloud_config (kubernetes-sigs#6321) Fix some doc links (kubernetes-sigs#6328) Use `connection: local` when `delegate_to: localhost` (kubernetes-sigs#6322) Add /dev volume (kubernetes-sigs#6319) Update cilium to 1.8.0 (kubernetes-sigs#6314) fix use of ansible tags (kubernetes-sigs#6316) ...
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In
kubeadm-configfile, the fieldruntime-configis always printed (as it's default to[]) even if empty. This is unnecessary and weird.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: