Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dns_etchosts #6236

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Add support for dns_etchosts #6236

merged 1 commit into from
Jun 26, 2020

Conversation

caruccio
Copy link
Contributor

@caruccio caruccio commented Jun 4, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR adds the ability to specificy an /etc/hosts-like file using coredns hosts plugin.
this is useful when one has no write access to DNS records and what use external hostnames instead ip address in many situations like monitoring, logging and external services.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @caruccio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2020
@floryut
Copy link
Member

floryut commented Jun 4, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2020
@floryut
Copy link
Member

floryut commented Jun 5, 2020

@caruccio You need to rebase master, CI error regarding crio were fixed recently

@caruccio caruccio force-pushed the dns_etchosts branch 2 times, most recently from f8b4f86 to 4b6c6e4 Compare June 5, 2020 17:59
@caruccio
Copy link
Contributor Author

caruccio commented Jun 5, 2020

@floryut rebased and squashed ;)

@caruccio
Copy link
Contributor Author

caruccio commented Jun 5, 2020 •
edited
Loading

@floryut some tests have failed aparently for issues unrelated to PR. Can you replay those specific steps?

@floryut
Copy link
Member

floryut commented Jun 9, 2020

@floryut some tests have failed aparently for issues unrelated to PR. Can you replay those specific steps?

Sorry again, you'll need to rebase master again, we had another CI issue :<

@caruccio
Copy link
Contributor Author

caruccio commented Jun 9, 2020

@floryut ahoy! rebased and tests passed. lgtm?

@LuckySB
Copy link
Contributor

LuckySB commented Jun 9, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caruccio, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@caruccio
Copy link
Contributor Author

hey @LuckySB @EppO @holmsten what do we need for a /merge?

@floryut
Copy link
Member

floryut commented Jun 26, 2020

/lgtm
@caruccio that :) sorry

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1892cd6 into kubernetes-sigs:master Jun 26, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
@caruccio @LuckySB
Add support for dns_etchosts (kubernetes-sigs#6236)
421554b
erulabs added a commit to kubesail/kubespray that referenced this pull request Jun 30, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
9edd12d 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (22 commits)
  Remove runtime-config from kubeadm if empty (kubernetes-sigs#6311)
  Update deprecated api (kubernetes-sigs#6245)
  Update kube-router to 1.0.0 (kubernetes-sigs#6211)
  Fix kubelet cgroup driver detection for crio (kubernetes-sigs#6331)
  Update hashes and set default version to 1.18.5 (kubernetes-sigs#6335)
  Change MetalLB to one of addons (kubernetes-sigs#6238)
  Update calico to 1.15.0 + minor update to kube-ovn/weave (kubernetes-sigs#6306)
  Add .editorconfig file (kubernetes-sigs#6307)
  Use NetworkManager to manage resolv.conf in FedoraCoreOS (kubernetes-sigs#6291)
  Add USE_REAL_HOSTNAME to inventory.py (kubernetes-sigs#6293)
  Cleanup OpenStack network things (kubernetes-sigs#6283)
  Add support for dns_etchosts (kubernetes-sigs#6236)
  kube_encryption_resources must be output as yaml (kubernetes-sigs#6309)
  Gather ansible_default_ipv4 for specific groups (kubernetes-sigs#6318)
  added azure_cloud parameter to Azure's cloud_config (kubernetes-sigs#6321)
  Fix some doc links (kubernetes-sigs#6328)
  Use `connection: local` when `delegate_to: localhost` (kubernetes-sigs#6322)
  Add /dev volume (kubernetes-sigs#6319)
  Update cilium to 1.8.0 (kubernetes-sigs#6314)
  fix use of ansible tags (kubernetes-sigs#6316)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caruccio @k8s-ci-robot @floryut @LuckySB