feat: expose os_disk_size_db to allow overriding

[mweibel]

What this PR does / why we need it:

Allows overriding VM os disk size.

[k8s-ci-robot]

Hi @mweibel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kkeshavamurthy]

/ok-to-test

[mweibel]

thanks @kkeshavamurthy
Since the tests failed I was so free to add also shared image gallery storage_account_type as a variable, since I need this too.

The pull_azure_sigs test job: I'm not sure if there's an issue with that test. It fails with pip not found.

[mweibel]

oh - shared_image_gallery.storage_account_type requires packer 1.7.3. I don't suppose it'd be possible to upgrade packer? :)

I'll revert that change then.

[jsturtevant]

Looks like might be: hashicorp/packer-plugin-azure#41 (comment)?

[mweibel]

@jsturtevant oh yes, it seems like

after digging through the logs (TIL that the prow main logs might not be actually relevant as to what failed) I found that the sig-windows-2019 build failed:

sig-windows-2019: FAILED. See logs in the artifacts folder.
sig-centos-7-gen2: SUCCESS
sig-ubuntu-2004-gen2: SUCCESS
sig-windows-2022-containerd: SUCCESS
sig-centos-7: SUCCESS
sig-flatcar: SUCCESS
sig-ubuntu-1804: SUCCESS
sig-flatcar-gen2: SUCCESS
sig-ubuntu-1804-gen2: SUCCESS
sig-windows-2019-containerd: SUCCESS
sig-ubuntu-2004: SUCCESS
+ EXIT_VALUE=1
+ set +o xtrace

looking at the logs:

�[1;32m==> sig-windows-2019: ERROR: -> PropertyChangeNotAllowed : Changing property 'sourceVirtualMachine' is not allowed.

[...]

�[1;31mBuild 'sig-windows-2019' errored after 28 minutes 20 seconds: unexpected EOF�[0m

==> Wait completed after 28 minutes 20 seconds

==> Some builds didn't complete successfully and had errors:
--> sig-windows-2019: unexpected EOF

What can I do about this? just retest and hope for the best?

[kkeshavamurthy]

I think the reason this Azure SIG test fail often is windows-2019 and windows-2019-containerd SIG end up with the same SIG Image Name. Whichever of the 2 builds completes second tries to create a SIG Image in the Gallery with the image name that already exists and fails.

Windows-2019 SIG image info:

�[1;32m==> sig-windows-2019:  -> Compute ResourceGroupName : 'pkr-Resource-Group-jb6x9uvqz8'�[0m
�[1;32m==> sig-windows-2019:  -> Compute Name              : 'pkrvmjb6x9uvqz8'�[0m
�[1;32m==> sig-windows-2019:  -> Compute Location          : 'eastus2'�[0m
�[1;32m==> sig-windows-2019:  -> Image ResourceGroupName   : 'image-builder-e2e-6vf1l8'�[0m
�[1;32m==> sig-windows-2019:  -> Image Name                : 'capi-windows-2019-1660288896'�[0m
�[1;32m==> sig-windows-2019:  -> Image Location            : 'eastus2'�[0m
�[1;32m==> sig-windows-2019: ERROR: -> PropertyChangeNotAllowed : Changing property 'sourceVirtualMachine' is not allowed.

SIG Windows-2019-Containerd info:

�[1;32m==> sig-windows-2019-containerd: Capturing image ...�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Compute ResourceGroupName : 'pkr-Resource-Group-30uqf66a45'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Compute Name              : 'pkrvm30uqf66a45'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Compute Location          : 'eastus2'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Image ResourceGroupName   : 'image-builder-e2e-6vf1l8'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Image Name                : 'capi-windows-2019-1660288896'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Image Location            : 'eastus2'�[0m
�[1;32m==> sig-windows-2019-containerd: Publishing to Shared Image Gallery ...�[0m
�[1;32m==> sig-windows-2019-containerd:  -> MDI ID used for SIG publish           : '/subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/image-builder-e2e-6vf1l8/providers/Microsoft.Compute/images/capi-windows-2019-1660288896'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG publish resource group            : 'image-builder-e2e-6vf1l8'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG gallery name                      : 'ClusterAPI1660288827fxzt'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG image name                        : 'capi-windows-2019-containerd'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG image version                     : '0.3.1660288896'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG replication regions               : '[eastus2]'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG image version endoflife date      : ''�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG image version exclude from latest : 'false'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> SIG replica count [1, 10]             : '1'�[0m
�[1;32m==> sig-windows-2019-containerd:  -> Shared Gallery Image Version ID : '/subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/image-builder-e2e-6vf1l8/providers/Microsoft.Compute/galleries/ClusterAPI1660288827fxzt/images/capi-windows-2019-containerd/versions/0.3.1660288896'�[0m
�[1;32m==> sig-windows-2019-containerd: 

Image Name                : 'capi-windows-2019-1660288896

is the same for both.

On a successful build:

�[1;32m==> sig-windows-2019-containerd:  -> Image Name                : 'capi-windows-2019-1660180017'�[0m

�[1;32m==> sig-windows-2019:  -> Image Name                : 'capi-windows-2019-1660180016'�[0m

CC: @jsturtevant

[kkeshavamurthy]

/test pull-azure-sigs

[kkeshavamurthy]

Thanks for the PR @mweibel
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkeshavamurthy, mweibel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• images/capi/packer/azure/OWNERS [kkeshavamurthy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment