azure arm: support for shared image gallery storage account type #10863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwampDragons
force-pushed
the
az-sig-account
branch
from
d815945
to
7732b9e
Compare
|
rebased to resolve conflicts. |
SwampDragons
force-pushed
the
az-sig-account
branch
from
7732b9e
to
9441a69
Compare
|
Thanks for this contribution! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
This PR is to add Azure plugin support, allowing storage_account_type to be set on shared_image_gallery_destination. Adds the ability for the configuration to specify
Standard_LRSorStandard_ZRSstorage account types, with a default ofStandard_LRS. Also adds a config test to fail validation on incorrect configuration.I did my best to make sure that the new argument was included in the docs, but it doesn't look like the SharedImageGalleryDestination partial is being referenced. Docs have been updated to include an example of the new argument.
Let me know if there's anything else. Thanks!
Closes #10313