Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows-2019 and -2025 targets from CI #1604

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mboersma
Copy link
Contributor

Change description

Removes the Azure windows-2019 and windows-2025 targets from CI runs, since they are both failing and blocking unrelated PRs from merging.

Related issues

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2024
@mboersma
Copy link
Contributor Author

/test pull-azure-vhds
/test pull-azure-sigs

@AverageMarcus
Copy link
Member

@mboersma Are these targets actually broken or just in CI? As in, do we want to drop support for building these completely?

@mboersma
Copy link
Contributor Author

/test pull-azure-sigs

@AverageMarcus, as far as I can tell, the windows-2019 targets are broken and maybe we should remove them altogether, although @jsturtevant should weigh in. The windows-2025 target supposedly only fails in CI, and needs to be fixed and supported.

@mboersma
Copy link
Contributor Author

/test pull-azure-sigs

Two unrelated flakes and a timeout. :-( Not sure why things are going badly here, I'm running ./images/capi/scripts/ci-azure-e2e.sh locally to see if I can reproduce.

@jsturtevant
Copy link
Contributor

jsturtevant commented Oct 15, 2024

/lgtm
/approve

The time of the failures aligns with patch Tuesday last week. 2019 is technically EOL and only receiving security patches right now so likely ok to remove from CI.

@TinaMor fyi on 2025, hopefully we just need to increase the timeout to make this pass.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit c298335 into kubernetes-sigs:main Oct 15, 2024
8 checks passed
@mboersma mboersma deleted the skip-broken-windows branch October 15, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants