Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install gcloud from rpm on gce rhel8 #1600

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Oct 14, 2024

Change description

Fixes #1516 by installing gcloud from an RPM rather than a script if the distro is RedHat.

Related issues

Additional context

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@mboersma mboersma marked this pull request as ready for review October 14, 2024 21:09
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2024
@mboersma
Copy link
Contributor Author

/test pull-image-builder-gcp-all

@mboersma
Copy link
Contributor Author

/test pull-image-builder-gcp-all

Looks like this fixed it. I'm just moving the symlink step inside the "!= RedHat" block.

@mboersma
Copy link
Contributor Author

This does fix #1516, but we may need #1604 to merge before it will pass.

Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@mboersma
Copy link
Contributor Author

/retest

@AverageMarcus
Copy link
Member

@mboersma this one good to merge in now? Need an approve?

@mboersma
Copy link
Contributor Author

@AverageMarcus should be good to go, yes thanks.

@AverageMarcus
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9329300 into kubernetes-sigs:main Oct 15, 2024
9 checks passed
@mboersma mboersma deleted the fix-gce-rhel8 branch October 15, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RHEL 8 build broken for GCE
3 participants