Clarifying Redirect Support levels #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/cc @hbagdi |
robscott
commented
Jul 15, 2021
| @@ -657,23 +657,31 @@ type HTTPRequestRedirect struct { | |||
| // header in the response. | |||
| // When empty, the protocol of the request is used. | |||
| // | |||
| // Support: Extended | |||
There was a problem hiding this comment.
For GCP we have some cases where we just support same protocol or HTTP->HTTPS, not HTTPS->HTTP. I think that means this field should be extended.
robscott
commented
Jul 15, 2021
| // +optional | ||
| Hostname *string `json:"hostname,omitempty"` | ||
| // Port is the port to be used in the value of the `Location` | ||
| // header in the response. | ||
| // When empty, port (if specified) of the request is used. | ||
| // | ||
| // Support: Extended |
There was a problem hiding this comment.
Redirecting to arbitrary ports is not supported as broadly as I'd hoped.
This also documents how overlapping support levels should be interpreted.
robscott
force-pushed
the
redirect-support
branch
from
d6effa6 to
61c3797
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
This clarifies support levels in the Redirect filter and documents how overlapping support levels should be interpreted.
Does this PR introduce a user-facing change?: