Merge pull request #723 from robscott/redirect-support

Clarifying Redirect Support levels

apis/v1alpha2/httproute_types.go

@@ -657,23 +657,31 @@ type HTTPRequestRedirect struct {
 	// header in the response.
 	// When empty, the protocol of the request is used.
 	//
+	// Support: Extended
+	//
 	// +optional
 	// +kubebuilder:validation:Enum=HTTP;HTTPS
 	Protocol *string `json:"protocol,omitempty"`
 	// Hostname is the hostname to be used in the value of the `Location`
 	// header in the response.
 	// When empty, the hostname of the request is used.
 	//
+	// Support: Core
+	//
 	// +optional
 	Hostname *string `json:"hostname,omitempty"`
 	// Port is the port to be used in the value of the `Location`
 	// header in the response.
 	// When empty, port (if specified) of the request is used.
 	//
+	// Support: Extended
+	//
 	// +optional
 	Port *int `json:"port,omitempty"`
 	// StatusCode is the HTTP status code to be used in response.
 	//
+	// Support: Core
+	//
 	// +optional
 	// +kubebuilder:default=302
 	// +kubebuilder:validation=301;302

site-src/v1alpha2/concepts/guidelines.md

@@ -77,6 +77,22 @@ universal support will not be a blocker towards developing portable
 feature sets. Standardizing on spec will make it easier to eventually
 graduate to CORE when support is widespread.
 
+### Overlapping Support Levels
+It is possible for support levels to overlap. When this occurs, the minimum
+expressed support level should be interpreted. For example, an identical struct
+may be embedded in two different places. In one of those places, the struct is
+considered to have CORE support while the other place only includes EXTENDED
+support. Fields within this struct may express separate CORE and EXTENDED
+support levels, but those levels may never be interpreted as exceeding the
+support level of the parent struct they are embedded in.
+
+For a more concrete example, HTTPRoute includes CORE support for filters defined
+within a Rule and EXTENDED support when defined within ForwardTo. Those filters
+may separately define support levels for each field. When interpreting
+overlapping support levels, the minimum value should be interpreted. That means
+if a field has a CORE support level but is in a filter attached in a place with
+EXTENDED support, the interpreted support level should be EXTENDED.
+
 ### Conformance expectations
 
 We expect there will be varying levels of conformance among the