fix: the conformance suite FS is defaulted if not given #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
Sorry, I didn't notice that this already has the approved label. I added my LGTM, which merges it. 🥲 |
|
all good /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area conformance
/kind bug
What this PR does / why we need it:
If the suite is used as a library, the
DefaultOptionsmethod is not used, and instead theOptionsstruct is provided by the implementation. In that case, the FS needs to be always set, otherwise the tests fail. We need to add a default on such a field, so that in case it is not set, we use the default FS value.This problem has been surfaced by this discussion: #2864 (comment)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: