Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(conformance): upgrade gwapi version #5863

Merged
merged 7 commits into from
Apr 17, 2024
Merged

test(conformance): upgrade gwapi version #5863

merged 7 commits into from
Apr 17, 2024

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Apr 12, 2024

What this PR does / why we need it:

Update GWAPI to the last commit before GRPCRoute GA.

Which issue this PR fixes:

part of #5705

Special notes for your reviewer:

#5705 (comment)

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 15, 2024
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@26a36a4). Click here to learn what that means.
Report is 9 commits behind head on main.

❗ Current head 70caa7c differs from pull request most recent head 059960f. Consider uploading reports for the commit 059960f to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             main   #5863   +/-   ##
======================================
  Coverage        ?   67.9%           
======================================
  Files           ?     178           
  Lines           ?   18248           
  Branches        ?       0           
======================================
  Hits            ?   12399           
  Misses          ?    4878           
  Partials        ?     971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tao12345666333 tao12345666333 marked this pull request as ready for review April 15, 2024 16:31
@tao12345666333 tao12345666333 requested a review from a team as a code owner April 15, 2024 16:31
@tao12345666333 tao12345666333 mentioned this pull request Apr 15, 2024
4 tasks
@tao12345666333 tao12345666333 self-assigned this Apr 15, 2024
@tao12345666333 tao12345666333 added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API labels Apr 15, 2024
@tao12345666333 tao12345666333 added this to the KIC v3.2.x milestone Apr 15, 2024
@rainest
Copy link
Contributor

rainest commented Apr 15, 2024

To clarify, you mentioned in chat that this can cause a panic due to an upstream bug: do we have some workaround in place that allows us to merge this despite, is it unlikely enough to appear in practice that we can ignore it for now, or is it enough of a problem that we should hold off until upstream has a fix?

@tao12345666333
Copy link
Member Author

@rainest I have fixed the situation that may cause panic in this PR. Specifically, it is initialized using opts := conformance.DefaultOptions(t).

We can safely merge this PR without waiting for upstream updates.

randmonkey
randmonkey previously approved these changes Apr 16, 2024
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes just to have time to properly review the PR

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a nit left in the comment, lgtm 👍

test/conformance/gateway_conformance_test.go Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 enabled auto-merge (squash) April 17, 2024 12:41
@tao12345666333 tao12345666333 merged commit 8b9f267 into main Apr 17, 2024
36 checks passed
@tao12345666333 tao12345666333 deleted the upgrade-gwapi branch April 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants