-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(conformance): upgrade gwapi version #5863
Conversation
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
bd0d373
to
8bbc7a6
Compare
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5863 +/- ##
======================================
Coverage ? 67.9%
======================================
Files ? 178
Lines ? 18248
Branches ? 0
======================================
Hits ? 12399
Misses ? 4878
Partials ? 971 ☔ View full report in Codecov by Sentry. |
To clarify, you mentioned in chat that this can cause a panic due to an upstream bug: do we have some workaround in place that allows us to merge this despite, is it unlikely enough to appear in practice that we can ignore it for now, or is it enough of a problem that we should hold off until upstream has a fix? |
@rainest I have fixed the situation that may cause panic in this PR. Specifically, it is initialized using We can safely merge this PR without waiting for upstream updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes just to have time to properly review the PR
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a nit left in the comment, lgtm 👍
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
70caa7c
to
059960f
Compare
What this PR does / why we need it:
Update GWAPI to the last commit before GRPCRoute GA.
Which issue this PR fixes:
part of #5705
Special notes for your reviewer:
#5705 (comment)
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:- [ ] theCHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR