Conformance: update objects in MustApplyObjectsWithCleanup

[sadath-12]

What type of PR is this?

What this PR does / why we need it:
MustApplyObjectsWithCleanup updates the objects if they are already available available

Which issue(s) this PR fixes:

Fixes #2230

Does this PR introduce a user-facing change?:

Bug Fixes : Updates the resource objects instead of keeping them same if the resource already exists

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sadath-12 / name: syedsadath-17 (35c33e0, f578844, 392d014, 93dfcff, d8847d6, f02b593, 792836a, 4054892, 110d57c, 5cec72c, 83b6615, 0490ef1, fd3a72d, 18e3bc9, ec3416e, e1e7d87, 9b8056e, ad60bb4)

[k8s-ci-robot]

Welcome @sadath-12!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sadath-12. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[youngnick]

/ok-to-test

[sadath-12]

/test pull-gateway-api-verify

[LiorLieberman]

/cc

[LiorLieberman]

Thanks @sadath-12 , left a few comments

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadath-12
Once this PR has been reviewed and has the lgtm label, please assign arkodg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• conformance/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadath-12]

@LiorLieberman any further suggestions on the updated on code ?

[LiorLieberman]

Thanks @sadath-12 , apart from two small comments, looks good to me.
Did you test it locally ? I can help with explaining how if you need.

[sadath-12]

Thanks @sadath-12 , apart from two small comments, looks good to me. Did you test it locally ? I can help with explaining how if you need.

Thank you @LiorLieberman , Yes I tried creating a secret in the cluster with same resource specifications but with different data and passed it to this function (which creates the secret with another data) and that seems to give me the modified data content on the secret

[LiorLieberman]

Can you test that the conformance tests are passing? Using the makefile I sent you for example in envoy-gw. ( https://github.com/envoyproxy/gateway/blob/554176b8cbbc5ffa627dc7109e1b3d2b59474e99/tools/make/kube.mk#L95 ) Remove the “delete-cluster” from the end of the line, it will spin up a kind cluster with meta lb and will leave it there. Then you can run locally from the gateway-api repo folder (that contains your changes). one with cleanup `go test -v ./conformance --gateway-class=envoy-gateway --cleanup-base-resources=true` and one without `go test -v ./conformance --gateway-class=envoy-gateway --cleanup-base-resources=false` w

…

On Wed, 13 Sept 2023 at 07:40, syedsadath-17 ***@***.***> wrote: Thanks @sadath-12 <https://github.com/sadath-12> , apart from two small comments, looks good to me. Did you test it locally ? I can help with explaining how if you need. Thank you @LiorLieberman <https://github.com/LiorLieberman> , Yes I tried creating a secret in the cluster with same resource specifications but with different data and passed it to this function (which creates the secret with another data) and that seems to give me the modified data content on the secret — Reply to this email directly, view it on GitHub <#2380 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASLANQQQ6NY3QNITNBP6ALTX2FIN7ANCNFSM6AAAAAA4OGL3MY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[k8s-ci-robot]

@sadath-12: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gateway-api-verify	ad60bb4	link	true	/test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[robscott]

Looks like this PR has gone stale so I'm going to close it out for now. Feel free to reopen if you find time to work on it again.