Skip to content

Commit 83b6615

Browse files
committed
Fix: MustApplyObjectsWithCleanup
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
1 parent 5cec72c commit 83b6615

File tree

2 files changed

+16
-25
lines changed

2 files changed

+16
-25
lines changed

conformance/mesh/manifests.yaml

+1-24
Original file line numberDiff line numberDiff line change
@@ -171,27 +171,4 @@ spec:
171171
image: gcr.io/k8s-staging-gateway-api/echo-server:v20230505-v0.7.0-rc1-10-g497e67da
172172
imagePullPolicy: IfNotPresent
173173

174-
---
175-
176-
apiVersion: apps/v1
177-
kind: Deployment
178-
metadata:
179-
name: echo-v1
180-
namespace: gateway-conformance-mesh-consumer
181-
labels:
182-
app: echo-v2
183-
spec:
184-
selector:
185-
matchLabels:
186-
app: echo-v2
187-
version: v1
188-
template:
189-
metadata:
190-
labels:
191-
app: echo-v2
192-
version: v1
193-
spec:
194-
containers:
195-
- name: echo
196-
image: gcr.io/k8s-staging-gateway-api/echo-server:v20230505-v0.7.0-rc1-10-g497e67da
197-
imagePullPolicy: IfNotPresent
174+

conformance/utils/kubernetes/apply.go

+15-1
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,26 @@ func (a Applier) MustApplyObjectsWithCleanup(t *testing.T, c client.Client, time
154154
t.Logf("Creating %s %s", resource.GetName(), resource.GetObjectKind().GroupVersionKind().Kind)
155155
err = c.Create(ctx, resource)
156156
require.NoError(t, err, "error creating resource")
157+
158+
if cleanup {
159+
t.Cleanup(func() {
160+
ctx, cancel = context.WithTimeout(context.Background(), timeoutConfig.DeleteTimeout)
161+
defer cancel()
162+
t.Logf("Deleting %s %s", resource.GetName(), resource.GetObjectKind().GroupVersionKind().Kind)
163+
err = c.Delete(ctx, resource)
164+
require.NoErrorf(t, err, "error deleting resource")
165+
})
166+
}
167+
168+
continue
169+
157170
}
158171
// Resource exists, update it
159172
t.Logf("Updating %s %s", resource.GetName(), resource.GetObjectKind().GroupVersionKind().Kind)
160173

161174
resource.SetResourceVersion(existingResource.GetResourceVersion())
162175

163176
err = c.Update(ctx, resource)
164-
require.NoError(t, err, "error updating resource")
165177

166178
if cleanup {
167179
t.Cleanup(func() {
@@ -172,6 +184,8 @@ func (a Applier) MustApplyObjectsWithCleanup(t *testing.T, c client.Client, time
172184
require.NoErrorf(t, err, "error deleting resource")
173185
})
174186
}
187+
188+
require.NoErrorf(t, err, "error updating resource")
175189
}
176190
}
177191

0 commit comments

Comments
 (0)