-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gep-1742.md to add more Nginx's timeout settings #2152
Conversation
according to the suggestion in kubernetes-sigs#2117 (review) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Hi @spacewander. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pleshakov |
Thanks @spacewander! Here's the deploy preview if that's easier to review: https://deploy-preview-2152--kubernetes-sigs-gateway-api.netlify.app/geps/gep-1742/#nginx-timeouts. /ok-to-test |
@robscott: GitHub didn't allow me to request PR reviews from the following users: brianehlert, pleshakov. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
geps/gep-1742.md
Outdated
Note Right of U: keepalive_timeout (if keepalive enabled) | ||
deactivate P | ||
Note left of P: send_timeout (only between two successive write operations) | ||
Note right of P: Repeat if connection is shared until server's keepalive_timeout is hit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this note based on its position still refers to the connection between Nginx and the Upstream. So I suggest updating it description, removing keepalive_timeout since it's already mentioned on the right of U:
Note right of P: Repeat if connection is shared until server's keepalive_timeout is hit | |
Note right of P: Repeat if connection is shared |
Would it make sense to add server's keepalive_timeout
to the left of C after "Finishes Response"? This will be similar to Envoy's and HAProxy's diagrams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pleshakov
Thanks for your suggestion! Would you review my latest change?
Thanks @spacewander! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pleshakov, robscott, spacewander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
according to the suggestion in #2117 (review)
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Improve #2117
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: