Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gep-1742.md to add more Nginx's timeout settings #2152

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

spacewander
Copy link
Contributor

according to the suggestion in #2117 (review)

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Improve #2117

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

according to the suggestion in kubernetes-sigs#2117 (review)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @spacewander. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spacewander
Copy link
Contributor Author

@pleshakov
Please take a look, thanks!

@robscott
Copy link
Member

Thanks @spacewander! Here's the deploy preview if that's easier to review: https://deploy-preview-2152--kubernetes-sigs-gateway-api.netlify.app/geps/gep-1742/#nginx-timeouts.

/ok-to-test
/cc @brianehlert @pleshakov

@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: brianehlert, pleshakov.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks @spacewander! Here's the deploy preview if that's easier to review: https://deploy-preview-2152--kubernetes-sigs-gateway-api.netlify.app/geps/gep-1742/#nginx-timeouts.

/ok-to-test
/cc @brianehlert @pleshakov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 28, 2023
geps/gep-1742.md Outdated
Note Right of U: keepalive_timeout (if keepalive enabled)
deactivate P
Note left of P: send_timeout (only between two successive write operations)
Note right of P: Repeat if connection is shared until server's keepalive_timeout is hit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this note based on its position still refers to the connection between Nginx and the Upstream. So I suggest updating it description, removing keepalive_timeout since it's already mentioned on the right of U:

Suggested change
Note right of P: Repeat if connection is shared until server's keepalive_timeout is hit
Note right of P: Repeat if connection is shared

Would it make sense to add server's keepalive_timeout to the left of C after "Finishes Response"? This will be similar to Envoy's and HAProxy's diagrams.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pleshakov
Thanks for your suggestion! Would you review my latest change?

@robscott
Copy link
Member

Thanks @spacewander!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pleshakov, robscott, spacewander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5d9ad6e into kubernetes-sigs:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants