-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Nginx timeouts diagram to match Envoy's in gep-1742.md #2117
Conversation
Welcome @spacewander! |
Hi @spacewander. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @spacewander! Will defer to @pleshakov and/or @brianehlert to confirm. Here's the deploy preview for reference: https://deploy-preview-2117--kubernetes-sigs-gateway-api.netlify.app/geps/gep-1742/#nginx-timeouts /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spacewander! Will defer to @pleshakov and/or @brianehlert to confirm. Here's the deploy preview for reference: https://deploy-preview-2117--kubernetes-sigs-gateway-api.netlify.app/geps/gep-1742/#nginx-timeouts
the edits look good to me 👍
I noticed a few more missing timeouts:
- client_body_timeout between client and NGINX
- send_timeout between client and NGINX
- keepalive_timeout between NGINX and client
happy to add those things in a separate PR.
@pleshakov |
Thanks @spacewander and @pleshakov! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pleshakov, robscott, spacewander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
according to the suggestion in kubernetes-sigs#2117 (review)
according to the suggestion in kubernetes-sigs#2117 (review) Signed-off-by: spacewander <spacewanderlzx@gmail.com>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adjust the Nginx timeout diagram according to the Envoy's. For example, adding missing client side request timeout, moving connect timeout.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: