-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All route ResolvedRefs reasons added to docs #1316
All route ResolvedRefs reasons added to docs #1316
Conversation
Hi @mlavacca. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlavacca!
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
46bd928
to
682c0f3
Compare
Thanks @mlavacca! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
InvalidKind
andBackendNotFound
are added to the possible failure reasons of theResolvedRefsCondition
in the route godoc.Which issue(s) this PR fixes:
Fixes #1313
Does this PR introduce a user-facing change?: