Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing reasons in the ResolvedRefs RouteConditionType documentation #1313

Closed
mlavacca opened this issue Aug 11, 2022 · 0 comments · Fixed by #1316
Closed

Missing reasons in the ResolvedRefs RouteConditionType documentation #1313

mlavacca opened this issue Aug 11, 2022 · 0 comments · Fixed by #1316
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mlavacca
Copy link
Member

mlavacca commented Aug 11, 2022

What happened:
The ResolvedRefs Route condition (https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1beta1/shared_types.go#L227-L234) documentation does not include the reasons InvalidKind and BackendNotFound among the possible ones that make it False.

What you expected to happen:

Since this godoc section's purpose is to enumerate the possible reasons that may lead to having one ConditionStatus instead of another, it is needed to ensure its exhaustivity. Hence, InvalidKind and BackendNotFound should be added to the possible reasons that can make the Accepted route condition False in the godoc section.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@mlavacca mlavacca added the kind/bug Categorizes issue or PR as related to a bug. label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant