Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide admission server builds for CPU architectures other than amd64 #627

Closed
hbagdi opened this issue Apr 23, 2021 · 7 comments
Closed
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@hbagdi
Copy link
Contributor

hbagdi commented Apr 23, 2021

What would you like to be added:

Admission server builds are currently only available for amd64 architecture.
We should provide builds for other architectures as well.

Why is this needed:
Our users could be running k8s clusters on other CPU architectures.

@hbagdi hbagdi added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 23, 2021
@hbagdi
Copy link
Contributor Author

hbagdi commented Apr 23, 2021

For some context, #621 was the first attempt to get an image built and published. We decided to take an incremental approach to building out our images. There is no blocker for building docker images for other CPU architectures.

@robscott robscott added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 28, 2021
@youngnick youngnick added this to the v0.6.0 milestone Aug 4, 2022
@youngnick
Copy link
Contributor

/good-first-issue

Outstanding work here is to update our webhook admission build to some other architectures, linux/arm64 for certain, and to make sure we can add more if needed.

@k8s-ci-robot
Copy link
Contributor

@youngnick:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Outstanding work here is to update our webhook admission build to some other architectures, linux/arm64 for certain, and to make sure we can add more if needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 4, 2022
@youngnick youngnick mentioned this issue Sep 15, 2022
1 task
@akankshakumari393
Copy link
Member

/assign

@akankshakumari393
Copy link
Member

akankshakumari393 commented Sep 25, 2022

Quick question -

  1. what all arch do we want to add? I have already added ard64 and arm64 .
  2. All arch images need to use to repo that has arch information in its name, earlier we were using ${REGISTRY}/admission-server:${VERSION_TAG}. Now it should be ${REGISTRY}/admission-server-${ARCH}:${VERSION_TAG}. So do we need to create new repo or is it handled by infra team.

@youngnick
Copy link
Contributor

I think that amd64 and arm64 are probably okay for now, we can add more later if required.

I didn't know that was a requirement, maybe we can check with some other things like ingress-nginx as to how they handle this (I don't think that other Kubernetes projects have the arch in the repo name?)

@robscott robscott modified the milestones: v0.6.0, v0.6.1 Nov 4, 2022
@shaneutt shaneutt modified the milestones: v0.6.1, v0.6.0 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants