Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: support non-amd64 architectures #1295

Closed
howardjohn opened this issue Aug 4, 2022 · 4 comments · Fixed by #1327
Closed

conformance: support non-amd64 architectures #1295

howardjohn opened this issue Aug 4, 2022 · 4 comments · Fixed by #1327
Assignees

Comments

@howardjohn
Copy link
Contributor

Similar to #627, we should publish all images used in conformance tests with multi-arch support.

One thing that confused me is @mikemorris seemed to suggest we picked the image we use because it supports arm64: kubernetes/kubernetes#110605 (comment). However, I do not see the same:

$ crane manifest k8s.gcr.io/ingressconformance/echoserver:v0.0.1
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
   "config": {
      "mediaType": "application/vnd.docker.container.image.v1+json",
      "size": 2026,
      "digest": "sha256:3cb9c24fedce680ad075cdc5d3d4037e306217fa1824344a54a0bd1d65a98654"
   },
   "layers": [
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 639433,
         "digest": "sha256:5c7fe08dec514a5105d43dfcae1a5a45be002bcd3251dd178ced702aecfb7531"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 2317481,
         "digest": "sha256:d6a250117705cac0781f5218e3753ba42a048ebbc49150b39e9a42dce0b189ef"
      }
   ]
}
@howardjohn
Copy link
Contributor Author

I think the source is https://github.com/kubernetes-sigs/ingress-controller-conformance/tree/master/images/echoserver - It should be easy to change and I am happy to do it, just not sure how to actually get it published

@howardjohn
Copy link
Contributor Author

/assign @howardjohn

I'll need help getting it published officially though

@mikemorris
Copy link
Contributor

mikemorris commented Aug 22, 2022

Hmm, interesting that we had found this to work in practice previously without explicitly building arm64 images - not quite sure how it was working without digging deeper, but hashicorp/learn-consul-kubernetes#65 was the behavior we found where switching to this image was working on an M1 chip.

@howardjohn
Copy link
Contributor Author

howardjohn commented Aug 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants