Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test: Expected accepted condition of HTTPRoute in the case GatewayWithAttachedRoutes/unresolved-gateway-with-one-attached-unresolved-route is not clear #2526

Closed
randmonkey opened this issue Oct 26, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Oct 26, 2023

What happened:

notAccepted := metav1.Condition{
Type: string(v1.RouteConditionAccepted),
Status: metav1.ConditionTrue,

The name of the expected accepted condition is notAccepted, which indicate that the condition should have status false. However, the Status field is set to true, which is opposite to what the name indicates.

What you expected to happen:

Have a clear and consistent status of expected Accepted condition in status of testing HTTPRoute

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@randmonkey randmonkey added the kind/bug Categorizes issue or PR as related to a bug. label Oct 26, 2023
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 26, 2023
@arkodg
Copy link
Contributor

arkodg commented Oct 27, 2023

/close
fixed with #2535

@k8s-ci-robot
Copy link
Contributor

@arkodg: Closing this issue.

In response to this:

/close
fixed with #2535

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
No open projects
Development

No branches or pull requests

4 participants