Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support conformance test GatewayWithAttachedRoutes #4982

Closed
1 of 2 tasks
randmonkey opened this issue Oct 26, 2023 · 1 comment · Fixed by #4987
Closed
1 of 2 tasks

Support conformance test GatewayWithAttachedRoutes #4982

randmonkey opened this issue Oct 26, 2023 · 1 comment · Fixed by #4987
Assignees
@randmonkey
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API
Milestone
KIC v3.0.x

Comments

@randmonkey
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

The core conformance test GatewayWithAttachedRoutes added a test case "Gateway listener should have AttachedRoutes set even when Gateway has unresolved refs" which KIC could not pass yet.

Proposed Solution

  • modify the gateway controller to set attached routes even when gateway has unresolved refs

Additional information

No response

Acceptance Criteria

  • Passes the conformance test GatewayWithAttachedRoutes in gateway API 1.0.0-rc2
@randmonkey randmonkey added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API labels Oct 26, 2023
@randmonkey randmonkey added this to the KIC v3.0.0 milestone Oct 26, 2023
@randmonkey randmonkey mentioned this issue Oct 26, 2023
Merged
1 task
@randmonkey randmonkey self-assigned this Oct 26, 2023
@randmonkey
Copy link
Contributor Author

I found an inconsistency in the new added conformance test case and created an issue: kubernetes-sigs/gateway-api#2526

@randmonkey randmonkey mentioned this issue Oct 26, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randmonkey randmonkey

Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API
Projects
None yet
Milestone
KIC v3.0.x
1 participant
@randmonkey