Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump gateway APIs to 1.0.0-rc2 #4981

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Oct 26, 2023

What this PR does / why we need it:

bump gateway API to 1.0.0-rc2 and set skip of conformance tests in 1.0.0-rc2.

Which issue this PR fixes:

fixes #4916

Special notes for your reviewer:

related conformance failures (skips):

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner October 26, 2023 03:23
@randmonkey randmonkey added kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API labels Oct 26, 2023
@randmonkey randmonkey added this to the KIC v3.0.0 milestone Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (798f828) 77.6% compared to head (28b0fa2) 77.7%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4981   +/-   ##
=====================================
  Coverage   77.6%   77.7%           
=====================================
  Files        166     166           
  Lines      18624   18624           
=====================================
+ Hits       14466   14483   +17     
+ Misses      3321    3309   -12     
+ Partials     837     832    -5     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pangruoran pangruoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangruoran pangruoran enabled auto-merge (squash) October 26, 2023 07:14
@pangruoran pangruoran merged commit 7da78ac into main Oct 26, 2023
53 checks passed
@pangruoran pangruoran deleted the chore/bump_gatewayapi_1_0_rc2 branch October 26, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support conformance test GatewaySecretInvalidReferenceGrant
3 participants