Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The client is missing Apply() functions, making use alongside other client-go packages difficult #1639

Closed
therealmitchconnors opened this issue Jan 10, 2023 · 14 comments · Fixed by #2537
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@therealmitchconnors
Copy link

Since K8s 1.22, client-go has supported server-side-apply through functions like Apply(), ApplyStatus(), etc. Because the gateway api client library lacks these functions, it must be called in non-idiomatic ways, increasing friction for those who intend to automatically control gateways.

@therealmitchconnors therealmitchconnors added the kind/bug Categorizes issue or PR as related to a bug. label Jan 10, 2023
@shaneutt shaneutt added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 10, 2023
@shaneutt shaneutt added this to the v0.7.0 milestone Jan 10, 2023
@kundan2707
Copy link
Contributor

/assign

@howardjohn
Copy link
Contributor

Just FYI this is going to have a real world negative impact on all users: kubernetes/kubernetes#101384

@dprotaso
Copy link
Contributor

Could you maintain the server-side apply client in a separate package - so it's opt-in?

@kundan2707 kundan2707 removed their assignment Feb 2, 2023
@Sajiyah-Salat
Copy link
Contributor

Hello, I want to work on this issue. But I cant see the whole picture. A more detailed description and some resource links would be helpful. Thank you.

@shaneutt shaneutt added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 21, 2023
@shaneutt shaneutt modified the milestones: v0.7.0, v1.0.0 Feb 21, 2023
@ashutosh887
Copy link

I would like to work on this @shaneutt @therealmitchconnors

@shaneutt
Copy link
Member

Sounds good @ashutosh887, but since I've noticed that you've taken some other issues on in the last couple days: please note that this one could take some significant time, let us know if you get stuck or need any help along the way! 🖖

/assign @ashutosh887

@ashutosh887
Copy link

I'll try to work on it @shaneutt
Sure I'll let you know if I face any difficulty

@shaneutt
Copy link
Member

@ashutosh887 do you still have time for this? Anything we can do to help support you?

@shaneutt shaneutt removed this from the v1.0.0 milestone May 18, 2023
@shaneutt shaneutt removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 18, 2023
@therealmitchconnors
Copy link
Author

@shaneutt what needs to happen to move this forward? It was disappointing to see it removed from the GA tracker. SSA is the standard that K8s seems to be trying to get everyone to move to, but lack of support in critical libraries makes doing the right thing very difficult...

@dprotaso
Copy link
Contributor

FYI - there's a PR out here #2537

/unassign @ashutosh887
/assign @dprotaso

@k8s-ci-robot k8s-ci-robot assigned dprotaso and unassigned ashutosh887 Nov 30, 2023
@dprotaso
Copy link
Contributor

@howardjohn are the concerns in your comment still relevant?

@howardjohn
Copy link
Contributor

@howardjohn are the concerns in your comment still relevant?

Yes, but its not clear the impact. K8s types are far larger than gw-api, so it may not matter much in practice here.

@Bharadwajshivam28
Copy link

Hey @shaneutt I can take on this issue but I need some more details like steps to get started

@dprotaso
Copy link
Contributor

hey @Bharadwajshivam28 there's already a PR out of for this - #2537

Forgot to link it back to the issue.

Secondly, keep an eye on who's assigned to the issue cause if there's already someone assigned you don't want two people creating duplicate work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
8 participants