Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance RoundTripper should allow for custom http.RoundTripper implementation #1496

Closed
briantkennedy opened this issue Oct 31, 2022 · 11 comments
Assignees
Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@briantkennedy
Copy link
Contributor

What would you like to be added:

Allow for optionally constructing the roundtripper.DefaultRoundTripper with a custom http.RoundTripper.

Why this is needed:

Users may need to run conformance tests through a SSH tunnel or Proxy where a custom http.RoundTripper is required to connect to the load balancer.

type DefaultRoundTripper struct {

@briantkennedy briantkennedy added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 31, 2022
@shaneutt shaneutt added area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 1, 2022
@shaneutt shaneutt added this to the v0.7.0 milestone Nov 1, 2022
@akash-gautam
Copy link

/assign

@LiorLieberman
Copy link
Member

curios if there is any progress with it?

@akash-gautam
Copy link

@LiorLieberman Not yet, this one slipped out of my radar unfortunately. Will start on this soon.

@shaneutt shaneutt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 21, 2023
@shaneutt shaneutt modified the milestones: v0.7.0, v1.0.0 Mar 8, 2023
@ashutosh887
Copy link

@akash-gautam Should I give it a try now?
Please assign me @LiorLieberman

@robscott robscott assigned ashutosh887 and unassigned akash-gautam Mar 17, 2023
@robscott
Copy link
Member

Hey @ashutosh887, I think you're welcome to take this one on unless @akash-gautam is actively working on this. Thanks for volunteering!

@ashutosh887
Copy link

Thanks @robscott
I'll get started with it
Please guide me a bit what is needed to be fixed

@shaneutt
Copy link
Member

Just keep in mind @ashutosh887 that you've assigned multiple issues to yourself within a short period of time: it's often best to take one or two and focus in on those according to priority (priority labels, plus milestones). If you want to focus in more on #1515 or #1639 it would be OK to leave this one unassigned for now and come back to it OR open it up for other contributors to grab in the meantime (as this one is considered more of a long-term maintenance gain than a milestone deliverable).

As for your question: this issue is requesting that a RoundTripper option be made available in

type DefaultRoundTripper struct {
to override the defaults, which would enable running the test suite when a SSH tunnel or proxy is in place. If you do not have an implementation to test changes to this on, OR more specifically an implementation that would need to utilize an SSH tunnel or proxy, it may be better to leave this one for someone with an implementation with that need who can actively test it.

@shaneutt shaneutt added this to the v1.0.0 milestone Mar 20, 2023
@ashutosh887
Copy link

Thanks @shaneutt
Sure Sir... I respect your suggestions.

@ashutosh887 ashutosh887 removed their assignment Mar 20, 2023
@akash-gautam
Copy link

Starting work on this one today.
/assign

@akash-gautam
Copy link

This issue can be closed as per the discussions here

@robscott
Copy link
Member

Thanks @akash-gautam, sorry for the mixup!

@robscott robscott closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
@shaneutt shaneutt removed this from the v1.0.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants