-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance RoundTripper should allow for custom http.RoundTripper implementation #1496
Comments
/assign |
curios if there is any progress with it? |
@LiorLieberman Not yet, this one slipped out of my radar unfortunately. Will start on this soon. |
@akash-gautam Should I give it a try now? |
Hey @ashutosh887, I think you're welcome to take this one on unless @akash-gautam is actively working on this. Thanks for volunteering! |
Thanks @robscott |
Just keep in mind @ashutosh887 that you've assigned multiple issues to yourself within a short period of time: it's often best to take one or two and focus in on those according to priority (priority labels, plus milestones). If you want to focus in more on #1515 or #1639 it would be OK to leave this one unassigned for now and come back to it OR open it up for other contributors to grab in the meantime (as this one is considered more of a long-term maintenance gain than a milestone deliverable). As for your question: this issue is requesting that a
|
Thanks @shaneutt |
Starting work on this one today. |
This issue can be closed as per the discussions here |
Thanks @akash-gautam, sorry for the mixup! |
What would you like to be added:
Allow for optionally constructing the
roundtripper.DefaultRoundTripper
with a customhttp.RoundTripper
.Why this is needed:
Users may need to run conformance tests through a SSH tunnel or Proxy where a custom
http.RoundTripper
is required to connect to the load balancer.gateway-api/conformance/utils/roundtripper/roundtripper.go
Line 70 in 0adb8a8
The text was updated successfully, but these errors were encountered: