Skip to content

feat(Conformance): Add a header based filter to make a controllable epp behavior determined by request header. #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 6, 2025
Merged

feat(Conformance): Add a header based filter to make a controllable epp behavior determined by request header. #922

merged 9 commits into from
Jun 6, 2025
+320 −2

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jun 4, 2025 •
edited by danehans
Loading

  • Add a HeaderBasedTestingFilter filters Pods based on an address specified in the test-epp-endpoint-selection request header.
  • Based on the above filter, a new scheduler for testing is introduced. It can be enabled by setting ENABLE_REQ_HEADER_BASED_SCHEDULER_FOR_TESTING env var to true. The scheduler will only select the pod based on the endpoint specified in the request header.

This will be used for conformance test for proposal 004 (ref).

Fixes #893

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 4, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans June 4, 2025 20:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 4, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 6ca6130
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68427e24dfc20a00088c69ab
😎 Deploy Preview https://deploy-preview-922--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Jun 5, 2025

Add the issue #893 this PR is trying to solve.

nirrozenbaum
nirrozenbaum reviewed Jun 5, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is great!
it actually looks exactly as I would imagine if you had to tell me you need to write new plugins for your use case.

I left just a few minor nits. but overall this LGTM

@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Jun 5, 2025

Thank you for the detailed review! @nirrozenbaum

nirrozenbaum
nirrozenbaum reviewed Jun 6, 2025
View reviewed changes
@nirrozenbaum
Copy link
Contributor

@zetxqx This is great, thanks! 🙏🏼

/lgtm

  • I do have one point that I think we can improve which is switching the reference (instead of main reference conformance, do it other way around), but that requires more work and is out of scope for this PR. I’ll try to push it soon when I have availability.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@zetxqx zetxqx closed this Jun 6, 2025
@zetxqx zetxqx reopened this Jun 6, 2025
@zetxqx zetxqx closed this Jun 6, 2025
@zetxqx zetxqx reopened this Jun 6, 2025
@danehans
Copy link
Contributor

danehans commented Jun 6, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
This was referenced Jun 6, 2025
Merged
Merged
Merged
@k8s-ci-robot k8s-ci-robot merged commit 2ff46b5 into kubernetes-sigs:main Jun 6, 2025
8 checks passed
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 9, 2025
@zetxqx @shmuelk
feat(Conformance): Add a header based filter to make a controllable e…
d603d2d 
…pp behavior determined by request header. (kubernetes-sigs#922)

* Add inital head based filter for testing purpose.

* Move conformance scheduler to conformance folder.

* Rephrase comment.

* Rename folder.

* Delete the header based filter under epp.

* Fix header.

* Add path to Dockerfile.
This was referenced Jun 9, 2025
Closed
Closed
Merged
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
@zetxqx @rlakhtakia
feat(Conformance): Add a header based filter to make a controllable e…
0a90d60 
…pp behavior determined by request header. (kubernetes-sigs#922)

* Add inital head based filter for testing purpose.

* Move conformance scheduler to conformance folder.

* Rephrase comment.

* Rename folder.

* Delete the header based filter under epp.

* Fix header.

* Add path to Dockerfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@danehans danehans Awaiting requested review from danehans

Assignees

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conformance: Add Mock EPP

4 participants

@zetxqx @k8s-ci-robot @nirrozenbaum @danehans