Skip to content

Conversation

SinaChavoshi
Copy link
Contributor

This pr fixes a formatting issue in the report guide as well as adding instructions for test execution.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2025
Copy link

netlify bot commented May 27, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e98b5ac
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/685312087038dd00087d82f2
😎 Deploy Preview https://deploy-preview-878--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from danehans and kfswain May 27, 2025 22:32
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2025
@danehans
Copy link
Contributor

@SinaChavoshi thanks for creating these conformance docs. The docs need to be in site-src to get published to the docs site.

Consider adding your readme here: https://gateway-api-inference-extension.sigs.k8s.io/guides/implementers/#conformance-tests.

See these Make targets for building and locally serving the docs to review your changes.

@danehans
Copy link
Contributor

danehans commented Jun 6, 2025

@SinaChavoshi after #922 merges, please update this guide to explain that the conformance EPP is configured with the HeaderBasedTestingFilter (ENABLE_REQ_HEADER_BASED_SCHEDULER_FOR_TESTING=true env var in the EPP deployment manifest).

@SinaChavoshi
Copy link
Contributor Author

SinaChavoshi commented Jun 9, 2025

@SinaChavoshi after #922 merges, please update this guide to explain that the conformance EPP is configured with the HeaderBasedTestingFilter (ENABLE_REQ_HEADER_BASED_SCHEDULER_FOR_TESTING=true env var in the EPP deployment manifest).

ignore my earlier comment will fix this shortly .

@SinaChavoshi
Copy link
Contributor Author

SinaChavoshi commented Jun 9, 2025

@danehans @nirrozenbaum turns out that the current implementation of the EPP requires the InferencePool name to be provided explicit as a flag to EPP This does not allow us to create a shared EPP. I have created a separate issue #946 to discuss / track if we want to change this behaviour.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SinaChavoshi!

@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2025
Copy link
Contributor

@zetxqx zetxqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@zetxqx: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahg-g
Copy link
Contributor

ahg-g commented Jun 18, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, robscott, SinaChavoshi, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3cc7e3f into kubernetes-sigs:main Jun 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants