feat(conformance): Update InferencePoolResolvedRefsCondition test for E2E request validation #866

SinaChavoshi · 2025-05-22T22:17:20Z

This PR enhances the InferencePoolResolvedRefsCondition conformance test to add end-to-end request validation.

Key changes include:

Switched the backend from agnhost to the standard Gateway API echo-basic server ( leveraging the image from gateway project).
Updated the echoserver deployment with a stable image tag, corrected port (3000), and injected POD_NAME/NAMESPACE environment variables for accurate request detail reporting.
Refactored the Go test to use standard Gateway API HTTP utilities (gwhttp.MakeRequestAndExpectEventuallyConsistentResponse).
Enabled assertions for Host and Path as received by the backend, now feasible with the new echoserver.

Test results from local run on commit f956a09

go test -v ./conformance -args -debug     -gateway-class istio    -cleanup-base-resources=false -run-test InferencePoolResolvedRefsCondition
...
    apply.go:283: 2025-05-28T19:14:32.884490721Z: Deleting infra-backend-deployment Deployment
--- PASS: TestConformance (19.31s)
    --- SKIP: TestConformance/HTTPRouteInvalidInferencePoolRef (0.00s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
    --- PASS: TestConformance/InferencePoolResolvedRefsCondition (15.53s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_show_Accepted:True_by_parents_and_be_routable_via_multiple_HTTPRoutes (5.85s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-gw1_and_verify_InferencePool_status_and_routing_via_gw2 (5.58s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-gw2_and_verify_InferencePool_has_no_parent_statuses_and_is_not_routable (1.41s)
PASS
ok      sigs.k8s.io/gateway-api-inference-extension/conformance 19.519s

…s#865

netlify · 2025-05-22T22:17:25Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`c58befb`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/683774a56399dd0008a8906d
😎 Deploy Preview	https://deploy-preview-866--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-05-22T22:17:30Z

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans · 2025-05-27T16:45:11Z

@SinaChavoshi can you rebase when you have a moment?

ahg-g · 2025-05-28T14:45:24Z

/ok-to-test

SinaChavoshi · 2025-05-28T19:16:58Z

@SinaChavoshi can you rebase when you have a moment?

@danehans Done :)

danehans

The boilerplate header in conformance/utils/traffic/traffic.go was removed. Please add it back in a follow-up PR.

danehans · 2025-05-28T21:08:42Z

/lgtm
/approve

k8s-ci-robot · 2025-05-28T21:08:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, SinaChavoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danehans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SinaChavoshi · 2025-05-28T22:04:35Z

boilerplate header

good catch! done #883

… E2E request validation (kubernetes-sigs#866) * WIP tests for inferencepool_resolvedrefs_condition * update condition check * Add helper method for inf pool parrent status check * update manifests * update the test to match manifest * fix yaml files. * add SupportInferencePool * Add a helper function for HTTPRouteMustBeAcceptedAndResolved * Add a helper method InferencePoolMustBeAcceptedByParent * add todo for ensure http requests are routed correctly kubernetes-sigs#865 * Add http tests * update to use echo server instead * fix echo server port. * Add env var to include namespace and pod name for echo server resposne. * factor out the common HTTPResponse builder * shorten wait time * remove extra space * fix yaml formatting * clean up yaml file remove white space and optional fields. * change naming convention to primary secondary consistently. * add helper method for "MakeRequestAndExpectNotFound/Success * use config instead of inferenceconfig

SinaChavoshi added 15 commits May 14, 2025 19:07

WIP tests for inferencepool_resolvedrefs_condition

a72eef6

Merge branch 'main' into inf_pool_tests_10

6e5bf2a

update condition check

81f34af

Add helper method for inf pool parrent status check

a784717

update manifests

2efba17

update the test to match manifest

585ea79

fix yaml files.

707a19a

add SupportInferencePool

da149b0

Add a helper function for HTTPRouteMustBeAcceptedAndResolved

0eac6bb

Add a helper method InferencePoolMustBeAcceptedByParent

7fc82fc

add todo for ensure http requests are routed correctly kubernetes-sig…

ebce49e

…s#865

Add http tests

9b75c4d

update to use echo server instead

cb69fb9

fix echo server port.

6272d30

Add env var to include namespace and pod name for echo server resposne.

2b42e48

k8s-ci-robot requested review from Jeffwan and liu-cong May 22, 2025 22:17

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 22, 2025

SinaChavoshi added 2 commits May 22, 2025 22:32

factor out the common HTTPResponse builder

49671f8

shorten wait time

8503504

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2025

Merge branch 'main' into inf_pool_tests_14

8476e8f

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2025

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 27, 2025

SinaChavoshi added 2 commits May 27, 2025 21:13

remove extra space

a3f56a8

fix yaml formatting

7e71389

SinaChavoshi mentioned this pull request May 27, 2025

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Merged

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2025

SinaChavoshi mentioned this pull request May 28, 2025

feat(conformance): Add HTTPRouteMultipleRulesDifferentPools test #834

Merged

SinaChavoshi added 2 commits May 28, 2025 19:07

Merge branch 'main' into inf_pool_tests_14

23b1247

clean up yaml file remove white space and optional fields.

f956a09

SinaChavoshi added 3 commits May 28, 2025 19:25

change naming convention to primary secondary consistently.

2840b80

add helper method for "MakeRequestAndExpectNotFound/Success

00f6ab4

use config instead of inferenceconfig

c58befb

danehans reviewed May 28, 2025

View reviewed changes

k8s-ci-robot assigned danehans May 28, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025

k8s-ci-robot merged commit a1b7f59 into kubernetes-sigs:main May 28, 2025
8 checks passed

SinaChavoshi mentioned this pull request May 28, 2025

conformance: Add HTTP calls to validate E2E routing for inferencepool_resolvedrefs_condition test. #865

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(conformance): Update InferencePoolResolvedRefsCondition test for E2E request validation #866

feat(conformance): Update InferencePoolResolvedRefsCondition test for E2E request validation #866

Uh oh!

SinaChavoshi commented May 22, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 22, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented May 22, 2025

Uh oh!

danehans commented May 27, 2025

Uh oh!

ahg-g commented May 28, 2025

Uh oh!

SinaChavoshi commented May 28, 2025

Uh oh!

danehans left a comment

Uh oh!

danehans commented May 28, 2025

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

Uh oh!

SinaChavoshi commented May 28, 2025

Uh oh!

Uh oh!

feat(conformance): Update InferencePoolResolvedRefsCondition test for E2E request validation #866

feat(conformance): Update InferencePoolResolvedRefsCondition test for E2E request validation #866

Uh oh!

Conversation

SinaChavoshi commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented May 22, 2025

Uh oh!

danehans commented May 27, 2025

Uh oh!

ahg-g commented May 28, 2025

Uh oh!

SinaChavoshi commented May 28, 2025

Uh oh!

danehans left a comment

Choose a reason for hiding this comment

Uh oh!

danehans commented May 28, 2025

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

Uh oh!

SinaChavoshi commented May 28, 2025

Uh oh!

Uh oh!

SinaChavoshi commented May 22, 2025 •

edited

Loading

netlify bot commented May 22, 2025 •

edited

Loading