Skip to content

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented May 14, 2025

Adds a new conformance test (InferencePoolResolvedRefsCondition) to validate that an InferencePool correctly updates its status.parents[] when it is referenced and unreferenced by multiple gateways and HTTPRoutes.

The test ensures:

  • The InferencePool shows an Accepted condition from parent Gateways when referenced.
  • The parent statuses are cleared when references are removed.
go test -v ./conformance -args -debug     -gateway-class istio     -cleanup-base-resources=false -run-test InferencePoolResolvedRefsCondition
=== RUN   TestConformance
    conformance.go:196: Registering API types with scheme...
    conformance.go:196: Attempting to install inferencev1alpha2 types into scheme from package: inference.networking.x-k8s.io
    conformance.go:196: Populating SupportedFeatures with GatewayLayerProfile.CoreFeatures: [Gateway]
    conformance.go:196: Final opts.SupportedFeatures: [Gateway]
    conformance.go:196: Running Inference Extension conformance tests with GatewayClass istio
    conformance.go:196: RunConformanceWithOptions: BaseManifests path being used by opts: "resources/manifests/manifests.yaml"
    suite.go:348: 2025-05-20T23:30:35.213558999Z: Test Setup: Ensuring GatewayClass has been accepted
...
--- PASS: TestConformance (215.13s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
    --- PASS: TestConformance/InferencePoolResolvedRefsCondition (182.05s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_show_Accepted:True_by_parents_when_referenced_by_multiple_HTTPRoutes (0.05s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-gw1 (180.11s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_still_show_Accepted:True_by_parent_after_one_HTTPRoute_is_deleted (0.21s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-gw2 (0.09s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_have_no_parent_statuses_after_all_HTTPRoutes_are_deleted (0.04s)
PASS
ok  

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2025
Copy link

netlify bot commented May 14, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ccb96ff
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6835f598029d9b000898c462
😎 Deploy Preview https://deploy-preview-832--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from kfswain and liu-cong May 14, 2025 19:10
@k8s-ci-robot
Copy link
Contributor

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2025
@SinaChavoshi SinaChavoshi marked this pull request as ready for review May 20, 2025 23:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from robscott May 20, 2025 23:52
@SinaChavoshi SinaChavoshi changed the title feat(conformance): WIP tests for inferencepool_resolvedrefs_condition feat(conformance): tests for inferencepool_resolvedrefs_condition May 20, 2025
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SinaChavoshi, this is great!

@robscott
Copy link
Member

Thanks @SinaChavoshi!

/lgtm
/ok-to-test

Assigning a maintainer for approval:
/assign @kfswain @danehans

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 22, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 22, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@ahg-g
Copy link
Contributor

ahg-g commented May 28, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, SinaChavoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 440ca87 into kubernetes-sigs:main May 28, 2025
8 checks passed
irar2 pushed a commit to irar2/gateway-api-inference-extension that referenced this pull request Jun 3, 2025
…bernetes-sigs#832)

* WIP tests for inferencepool_resolvedrefs_condition

* update condition check

* Add helper method for inf pool parrent status check

* update manifests

* update the test to match manifest

* fix yaml files.

* add SupportInferencePool

* Add a helper function for HTTPRouteMustBeAcceptedAndResolved

* Add a helper method InferencePoolMustBeAcceptedByParent

* add todo for ensure http requests are routed correctly kubernetes-sigs#865

* remove extra space
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 3, 2025
…bernetes-sigs#832)

* WIP tests for inferencepool_resolvedrefs_condition

* update condition check

* Add helper method for inf pool parrent status check

* update manifests

* update the test to match manifest

* fix yaml files.

* add SupportInferencePool

* Add a helper function for HTTPRouteMustBeAcceptedAndResolved

* Add a helper method InferencePoolMustBeAcceptedByParent

* add todo for ensure http requests are routed correctly kubernetes-sigs#865

* remove extra space
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
…bernetes-sigs#832)

* WIP tests for inferencepool_resolvedrefs_condition

* update condition check

* Add helper method for inf pool parrent status check

* update manifests

* update the test to match manifest

* fix yaml files.

* add SupportInferencePool

* Add a helper function for HTTPRouteMustBeAcceptedAndResolved

* Add a helper method InferencePoolMustBeAcceptedByParent

* add todo for ensure http requests are routed correctly kubernetes-sigs#865

* remove extra space
@zetxqx zetxqx mentioned this pull request Jun 12, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants