Skip to content

removed double loop on docs in hermetic test #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

removed double loop on docs in hermetic test #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions test/integration/epp/hermetic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import (
"google.golang.org/protobuf/testing/protocmp"
"google.golang.org/protobuf/types/known/structpb"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/fields"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
Expand Down Expand Up @@ -1691,27 +1692,13 @@ func BeforeSuite() func() {
}

for _, doc := range docs {
inferenceModel := &v1alpha2.InferenceModel{}
if err = yaml.Unmarshal(doc, inferenceModel); err != nil {
obj := &unstructured.Unstructured{}
if err = yaml.Unmarshal(doc, obj); err != nil {
logutil.Fatal(logger, err, "Can't unmarshal object", "document", doc)
}
if inferenceModel.Kind == "InferenceModel" {
logger.Info("Creating inference model", "model", inferenceModel)
if err := k8sClient.Create(context.Background(), inferenceModel); err != nil {
logutil.Fatal(logger, err, "Unable to create inferenceModel", "modelName", inferenceModel.Name)
}
}
}
for _, doc := range docs {
inferencePool := &v1alpha2.InferencePool{}
if err = yaml.Unmarshal(doc, inferencePool); err != nil {
logutil.Fatal(logger, err, "Can't unmarshal object", "document", doc)
}
if inferencePool.Kind == "InferencePool" {
logger.Info("Creating inference pool", "pool", inferencePool)
if err := k8sClient.Create(context.Background(), inferencePool); err != nil {
logutil.Fatal(logger, err, "Unable to create inferencePool", "poolName", inferencePool.Name)
}
logger.Info("Creating object", "kind", obj.GetKind(), "object", obj)
if err := k8sClient.Create(context.Background(), obj); err != nil {
logutil.Fatal(logger, err, "Unable to create object", "object", obj.GetName())
}
}

Expand Down