Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

use unstructured instead of checking InferenceModel/InferencePool and unmarshalling to specific object

use unstructured instead of checking InferenceModel/InferencePool and unmarshalling to specific object

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and kfswain April 8, 2025 19:04
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 895f09a
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67f5732073828c00096369ac
😎 Deploy Preview https://deploy-preview-668--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator

kfswain commented Apr 8, 2025

Nice.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit e71fd92 into kubernetes-sigs:main Apr 8, 2025
7 of 8 checks passed
@nirrozenbaum nirrozenbaum deleted the integration branch April 8, 2025 20:39
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
use unstructured instead of checking InferenceModel/InferencePool and unmarshalling to specific object

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
use unstructured instead of checking InferenceModel/InferencePool and unmarshalling to specific object

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
use unstructured instead of checking InferenceModel/InferencePool and unmarshalling to specific object

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants