Skip to content

Bug fix - error calling gt: incompatible types for comparison: float64 and int #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Bug fix - error calling gt: incompatible types for comparison: float64 and int #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/charts/inferencepool/templates/epp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
- --lora-info-metric
- "" # Set an empty metric to disable LoRA metric scraping as they are not supported by Triton yet.
{{- end }}
{{- if gt .Values.inferenceExtension.replicas 1 }}
{{- if gt (.Values.inferenceExtension.replicas | int) 1 }}
- --ha-enable-leader-election
{{- end }}
# Pass additional flags via the inferenceExtension.flags field in values.yaml.
Expand All @@ -68,7 +68,7 @@ spec:
{{- toYaml .Values.inferenceExtension.extraContainerPorts | nindent 8 }}
{{- end }}
livenessProbe:
{{- if gt .Values.inferenceExtension.replicas 1 }}
{{- if gt (.Values.inferenceExtension.replicas | int) 1 }}
grpc:
port: 9003
service: liveness
Expand All @@ -80,7 +80,7 @@ spec:
initialDelaySeconds: 5
periodSeconds: 10
readinessProbe:
{{- if gt .Values.inferenceExtension.replicas 1 }}
{{- if gt (.Values.inferenceExtension.replicas | int) 1 }}
grpc:
port: 9003
service: readiness
Expand Down
2 changes: 1 addition & 1 deletion config/charts/inferencepool/templates/leader-election-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if gt .Values.inferenceExtension.replicas 1 }}
{{- if gt (.Values.inferenceExtension.replicas | int) 1 }}
---
kind: Role
apiVersion: rbac.authorization.k8s.io/v1
Expand Down