Skip to content

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Sep 22, 2025

Helm is failing with the error below:

helm template deepseek-r1 ./  

Error: template: inferencepool/templates/leader-election-rbac.yaml:1:7: executing "inferencepool/templates/leader-election-rbac.yaml" at <gt .Values.inferenceExtension.replicas 1>: error calling gt: incompatible types for comparison: float64 and int

Thanks @nicolexin for reporting this!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2025
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 50ac36b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68d1b9cc9c2fb3000893350b
😎 Deploy Preview https://deploy-preview-1630--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@liu-cong
Copy link
Contributor Author

cc @kfswain @nirrozenbaum

@kfswain
Copy link
Collaborator

kfswain commented Sep 22, 2025

To share the conversation had off github: https://stackoverflow.com/questions/73944131/facing-error-calling-ge-incompatible-types-for-comparison-in-helm-template

The issue is specifically this quote here: 'Actually, anything numeric that comes from values.yaml (or any similar source) is treated as a float, whereas the templates distinguish between float and int.'

/approve

Letting tests run and will stamp. Thanks @liu-cong !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3f2ac07 into kubernetes-sigs:main Sep 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants