-
Notifications
You must be signed in to change notification settings - Fork 180
Main uniquely name crbac #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main uniquely name crbac #1564
Conversation
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @Gregory-Pereira. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, Gregory-Pereira The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update, reversion PR against release branch is here: #1565 |
* uniquely name CRBAC Signed-off-by: greg pereira <grpereir@redhat.com> * bugfix with testing Signed-off-by: greg pereira <grpereir@redhat.com> --------- Signed-off-by: greg pereira <grpereir@redhat.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
The root cause of #1393 as an alternative solution. The issue behind this is that you cannot install 2 releases of the GIE inferencepool chart with the same release name but in different namespaces because helm fights over the ownership of the cluster RBAC. This is a key issue we have in llm-d where people try to deploy similar examples in parallel but cannot.
Does this PR introduce a user-facing change?:
There are no API changes here, it simply creates a separate naming convention for cluster scoped RBAC so that multiple releases with the same name but different namespaces can co-exist.
We will revert #1545 and close #1563 in favor of this merging against the main branch and then cherry pick into release branch