Skip to content

Conversation

Gregory-Pereira
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
The root cause of #1393 as an alternative solution. The issue behind this is that you cannot install 2 releases of the GIE inferencepool chart with the same release name but in different namespaces because helm fights over the ownership of the cluster RBAC. This is a key issue we have in llm-d where people try to deploy similar examples in parallel but cannot.

Does this PR introduce a user-facing change?:
There are no API changes here, it simply creates a separate naming convention for cluster scoped RBAC so that multiple releases with the same name but different namespaces can co-exist.

cc @nirrozenbaum @ahg-g @kfswain @liu-cong This is one of the criteria for release in llm-d for version v0.3.0

Signed-off-by: greg pereira <grpereir@redhat.com>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 7, 2025
Copy link

netlify bot commented Sep 7, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c27f9bd
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68bdebf2db63ff0009f36500
😎 Deploy Preview https://deploy-preview-1545--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Gregory-Pereira. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2025
@Gregory-Pereira Gregory-Pereira changed the base branch from main to release-1.0 September 7, 2025 20:33
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 7, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Sep 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Sep 10, 2025

/lgtm
/approve

I assume you tested this manually?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Gregory-Pereira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7d53aa0 into kubernetes-sigs:release-1.0 Sep 10, 2025
8 checks passed
@nirrozenbaum
Copy link
Contributor

@ahg-g @Gregory-Pereira this PR was targeting release 1.0 branch.
not exactly what I was expecting.

we should do this PR against main. release 1.0 was already published.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 10, 2025

oh, I didn't notice, we should have some sort of a special tag on the PR to allow merging on branches other than main.

@kfswain
Copy link
Collaborator

kfswain commented Sep 10, 2025

oh, I didn't notice, we should have some sort of a special tag on the PR to allow merging on branches other than main.

That's a good idea, its a subtle thing that's easy to miss, as we don't typically look for it. Cut: #1562

Gregory-Pereira added a commit to Gregory-Pereira/gateway-api-inference-extension that referenced this pull request Sep 10, 2025
k8s-ci-robot pushed a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants