cleanup: make port definitions symmetric and clean endpointPickerRef.port #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/M
Signed-off-by: Xiyue Yu <xiyue@google.com>
|
/hold as we'd better consolidate all PR changes into one PR and it will make the cherry pick into the release branch cleaner |
k8s-ci-robot
added
the
do-not-merge/hold
|
verified via |
|
/retest |
capri-xiyue
changed the title
k8s-ci-robot
added
size/L
robscott
approved these changes
Aug 27, 2025
robscott
reviewed
Aug 27, 2025
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
|
Thanks @capri-xiyue! /lgtm |
k8s-ci-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, kfswain, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kfswain
pushed a commit
that referenced
this pull request
Aug 28, 2025
…port (#1484) * make port definitions symmetric * fixed linter Signed-off-by: Xiyue Yu <xiyue@google.com> * change spec * clean comment * fixed port * change port default * fixed test * draft cel test * added cel test * Update api/v1/inferencepool_types.go Co-authored-by: Rob Scott <rob.scott87@gmail.com> * updated test --------- Signed-off-by: Xiyue Yu <xiyue@google.com> Co-authored-by: Rob Scott <rob.scott87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
context: #1173 (comment) and #1173 (comment)
Which issue(s) this PR fixes:
Fixes #
context of #1173 (comment) and #1173 (comment)
Does this PR introduce a user-facing change?: