Skip to content

Commit e58d830

Browse files
committed
updated test
1 parent da4a889 commit e58d830

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

config/crd/bases/inference.networking.k8s.io_inferencepools.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ spec:
113113
- name
114114
type: object
115115
x-kubernetes-validations:
116-
- message: port is required when kind is 'Service' and unset(default
117-
to 'Service')
116+
- message: port is required when kind is 'Service' or unspecified
117+
(defaults to 'Service')
118118
rule: self.kind != 'Service' || has(self.port)
119119
selector:
120120
description: |-

test/cel/inferencepool_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"time"
2424

2525
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
26-
2726
v1 "sigs.k8s.io/gateway-api-inference-extension/api/v1"
2827
)
2928

@@ -69,19 +68,17 @@ func TestValidateInferencePool(t *testing.T) {
6968
mutate: func(ip *v1.InferencePool) {
7069
// By setting Kind to an empty string, we rely on the API server's default value of "Service".
7170
ip.Spec.EndpointPickerRef.Kind = ""
72-
ip.Spec.EndpointPickerRef.Name = "vllm-llama3-8b-instruct-epp"
7371
ip.Spec.EndpointPickerRef.Port = nil
7472
},
75-
wantErrors: []string{"port is required when kind is 'Service' and unset(default to 'Service')"},
73+
wantErrors: []string{"port is required when kind is 'Service' or unspecified (defaults to 'Service')"},
7674
},
7775
{
7876
desc: "fails validation when kind is explicitly 'Service' and port is missing",
7977
mutate: func(ip *v1.InferencePool) {
8078
ip.Spec.EndpointPickerRef.Kind = "Service"
81-
ip.Spec.EndpointPickerRef.Name = "vllm-llama3-8b-instruct-epp"
8279
ip.Spec.EndpointPickerRef.Port = nil
8380
},
84-
wantErrors: []string{"port is required when kind is 'Service' and unset(default to 'Service')"},
81+
wantErrors: []string{"port is required when kind is 'Service' or unspecified (defaults to 'Service')"},
8582
},
8683
}
8784

0 commit comments

Comments
 (0)