Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions site-src/guides/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ This quickstart guide is intended for engineers familiar with k8s and model serv
=== "Latest Release"

```bash
VERSION=v0.3.0
kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/$VERSION/manifests.yaml
kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/latest/download/manifests.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I understand, Latest Release tab refers to the latest Release, not to latest main.
dev tag refers to latest, which should point to main branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see here.. @danehans exactly pushed a PR as preparation for v0.4 release:
https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1043/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirrozenbaum – Please check the URL in my commit message; it points to the asset files in the latest release.
Since the project doesn’t generate documentation for every release version but only maintains the latest, this PR saves you from having to update it with each release.
@danehans – Anyway, if you still prefer to handle this manually for safety, feel free to close this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfirtoledo right. my bad. I thought you were pointing to main. sorry.
yeah, I think using latest will save some tedious update on every release.

```

=== "Dev Version"
Expand Down