docs: update the Getting Started guide to use the latest CRDs #1045
Conversation
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @kfirtoledo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
| ```bash | ||
| VERSION=v0.3.0 | ||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/$VERSION/manifests.yaml | ||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/latest/download/manifests.yaml |
There was a problem hiding this comment.
as far as I understand, Latest Release tab refers to the latest Release, not to latest main.
dev tag refers to latest, which should point to main branch.
There was a problem hiding this comment.
see here.. @danehans exactly pushed a PR as preparation for v0.4 release:
https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1043/files
There was a problem hiding this comment.
@nirrozenbaum – Please check the URL in my commit message; it points to the asset files in the latest release.
Since the project doesn’t generate documentation for every release version but only maintains the latest, this PR saves you from having to update it with each release.
@danehans – Anyway, if you still prefer to handle this manually for safety, feel free to close this PR.
There was a problem hiding this comment.
@kfirtoledo right. my bad. I thought you were pointing to main. sorry.
yeah, I think using latest will save some tedious update on every release.
|
/ok-to-test leaving final stamp for @danehans |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfirtoledo, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@kfirtoledo thanks for the PR, I closed #1043 in favor of your PR. FYI I also created #1044 so other quickstart manifest references use a tagged release instead of |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…s#1045) Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
…s#1045) Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
…s#1045) Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
…s#1045) Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
…s#1045) Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Update the Getting Started guide to use the latest CRDs - https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/latest/download/manifests.yaml
(no need to update the doc for every version)