Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/charts/inferencepool/templates/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ subjects:
name: {{ include "gateway-api-inference-extension.name" . }}
namespace: {{ .Release.Namespace }}
roleRef:
apiGroup: rbac.authorization.k8s.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is this defaulted to rbac.authorization.k8s.io on newer k8s versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tried to run it under k8s v1.33.1 and had the same error.

error: error validating "config/manifests/inferencepool-resources.yaml": error validating data: ValidationError(ClusterRoleBinding.roleRef): missing required field "apiGroup" in io.k8s.api.rbac.v1.RoleRef; if you choose to ignore these errors, turn validation off with --validate=false

Client Version: v1.23.10
Server Version: v1.33.1


When I upgraded kubectl to a higher version, I didn't find any error:

Client Version: v1.33.2
Server Version: v1.33.1

and

Client Version: v1.33.2
Server Version: v1.27.3


So, it should be caused by the low version of kubectl. To be as compatible as possible with lower versions, it is recommended to add default values.

kind: ClusterRole
name: {{ include "gateway-api-inference-extension.name" . }}
---
Expand Down
1 change: 1 addition & 0 deletions config/manifests/inferencepool-resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,5 +117,6 @@ subjects:
name: default
namespace: default
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: pod-read
2 changes: 1 addition & 1 deletion site-src/guides/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ subjects:
name: inference-gateway-sa-metrics-reader
namespace: default
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: inference-gateway-metrics-reader
apiGroup: rbac.authorization.k8s.io
---
apiVersion: v1
kind: Secret
Expand Down
1 change: 1 addition & 0 deletions test/testdata/inferencepool-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,6 @@ subjects:
name: default
namespace: $E2E_NS
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: pod-read