-
Notifications
You must be signed in to change notification settings - Fork 179
[Fix] Missing property "apiGroup" error #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @maratrixx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
name: {{ include "gateway-api-inference-extension.name" . }} | ||
namespace: {{ .Release.Namespace }} | ||
roleRef: | ||
apiGroup: rbac.authorization.k8s.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so is this defaulted to rbac.authorization.k8s.io on newer k8s versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tried to run it under k8s v1.33.1 and had the same error.
error: error validating "config/manifests/inferencepool-resources.yaml": error validating data: ValidationError(ClusterRoleBinding.roleRef): missing required field "apiGroup" in io.k8s.api.rbac.v1.RoleRef; if you choose to ignore these errors, turn validation off with --validate=false
Client Version: v1.23.10
Server Version: v1.33.1
When I upgraded kubectl to a higher version, I didn't find any error:
Client Version: v1.33.2
Server Version: v1.33.1
and
Client Version: v1.33.2
Server Version: v1.27.3
So, it should be caused by the low version of kubectl. To be as compatible as possible with lower versions, it is recommended to add default values.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, maratrixx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix: 🐛 Missing property "apiGroup" error * fix: 🐛 Delete the duplicate apiGroup
* fix: 🐛 Missing property "apiGroup" error * fix: 🐛 Delete the duplicate apiGroup
* fix: 🐛 Missing property "apiGroup" error * fix: 🐛 Delete the duplicate apiGroup
When I was running
kubectl -f config/manifests/inferencepool-resources.yaml
, I encountered an error:K8s Version: v1.27.3