Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

This PR cleans up some leftovers from the big config api PR, like typos, not log errors when we return error (and then it's logged by the caller), and updates to almost all plugins to keep things consistent across the plugins.
still need to take care of:

  • DecisionTreeFilter cannot be used by the new config api. issue was opened Current Configuration API doesn't support DecisionTreeFilter #1011
  • Prefix Plugin need some more cleanup, the prefix.go file has much more than the plugin itself and it would be better to keep it more organized. deferred to a later PR that will be focused on prefix plugin cleanup and organization.

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit bb3d9f2
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68545dde7ce45f00080cf854
😎 Deploy Preview https://deploy-preview-1012--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and liu-cong June 19, 2025 10:58
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2025
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@nirrozenbaum
Copy link
Contributor Author

cc @ahg-g @kfswain

@shmuelk
Copy link
Contributor

shmuelk commented Jun 19, 2025

To properly configure the DecisionTreeFilter plugin needs some underlying plugin maintenance work.

I have a PR for that. On top of which I have the start of a factory function got the DecisionTreeFilter

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@nirrozenbaum
Copy link
Contributor Author

nirrozenbaum commented Jun 19, 2025

To properly configure the DecisionTreeFilter plugin needs some underlying plugin maintenance work.

I have a PR for that. On top of which I have the start of a factory function got the DecisionTreeFilter

@shmuelk sounds good. I have opened an issue for this #1011.
would be good if you assign yourself so that others won't start working on this in parallel.

@nirrozenbaum nirrozenbaum requested a review from shmuelk June 19, 2025 14:15
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit.

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@ahg-g
Copy link
Contributor

ahg-g commented Jun 19, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1362b14 into kubernetes-sigs:main Jun 19, 2025
9 checks passed
@nirrozenbaum nirrozenbaum deleted the cleanup branch June 19, 2025 19:47
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
* cleanup after config api pr was merged

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* minor changes

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* typo fix

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* add comment for how to register out of tree plugin

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 26, 2025
* cleanup after config api pr was merged

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* minor changes

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* typo fix

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* add comment for how to register out of tree plugin

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
EyalPazz pushed a commit to EyalPazz/gateway-api-inference-extension that referenced this pull request Jul 9, 2025
* cleanup after config api pr was merged

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* minor changes

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* typo fix

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* add comment for how to register out of tree plugin

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants