-
Notifications
You must be signed in to change notification settings - Fork 179
cleanup after config api PR was merged #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
To properly configure the DecisionTreeFilter plugin needs some underlying plugin maintenance work. I have a PR for that. On top of which I have the start of a factory function got the DecisionTreeFilter |
@shmuelk sounds good. I have opened an issue for this #1011. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one nit.
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* cleanup after config api pr was merged Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * minor changes Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * typo fix Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * add comment for how to register out of tree plugin Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
* cleanup after config api pr was merged Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * minor changes Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * typo fix Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * add comment for how to register out of tree plugin Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
* cleanup after config api pr was merged Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * minor changes Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * typo fix Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * add comment for how to register out of tree plugin Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
This PR cleans up some leftovers from the big config api PR, like typos, not log errors when we return error (and then it's logged by the caller), and updates to almost all plugins to keep things consistent across the plugins.
still need to take care of: