Remove creationTimestamp from generated CRD

[pgier]

controller-gen currently adds the metadata field creationTimestamp: null. I think this field should not be included in the CRD yaml since this value should be added by the server.

[uthark]

I did some digging and found out that this comes from JSON encoding.
What happens is that yaml.Marshal is called https://github.com/uthark/controller-tools/blob/master/pkg/genall/genall.go#L106.
This in turn calls json.Marshal https://github.com/kubernetes-sigs/yaml/blob/v1.1.0/yaml.go#L17
and it falls to the if f.omitEmpty && isEmptyValue(fv) check (https://golang.org/src/encoding/json/encode.go, line 747) and isEmptyValue returns false for empty meta.v1.Time (https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/time.go#L33-L35)

So, not sure this is easily fixable in this repo. (I'm not a maintainer, but was stumbling over the same issue)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[erikgb]

/remove-lifecycle rotten

[erikgb]

Thanks for the nice "digging" @uthark! I am experiencing this issue too, after operator-sdk migrated to kubebuilder. Since this happens to both generated YAML-files, CRD and operator Role, I think you are right that this a general issue with the YAML marshalling. Any ideas on how/where this issue can be resolved? It is a bit annoying to have to modify the generated files.....

[erikgb]

Probable root cause kubernetes/kubernetes#86811, and potential local fix: kubernetes/kubernetes#86811 (comment).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[camilamacedo86]

remove-lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[erikgb]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[erikgb]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shaneutt]

It seems like this is still an issue, how do we feel about re-opening this?

[asilverman]

/remove-lifecycle rotten

[asilverman]

/reopen

[k8s-ci-robot]

@asilverman: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pg-yang]

/reopen

It seems like this is still an issue, how do we feel about re-opening this?

This issue still exists, How about removing all nil fields from jsonObj , I think it's safe.

controller-tools/pkg/genall/genall.go

Line 181 in 73391d1

var jsonObj map[string]interface{}

I'm using kubebuilder to implement k8s operator, the generated creationTimestamp: null will be transformed to creationTimestamp: "null" by kustomize

[k8s-ci-robot]

@pg-yang: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

It seems like this is still an issue, how do we feel about re-opening this?

This issue still exists, How about removing all nil fields from jsonObj , it's safe.

controller-tools/pkg/genall/genall.go

Line 181 in 73391d1

var jsonObj map[string]interface{}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[joelanford]

/reopen
/assign

[k8s-ci-robot]

@joelanford: Reopened this issue.

In response to this:

/reopen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.