Adding Combo CLI Binary #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
awgreene
requested changes
Oct 25, 2021
internal/cmd/eval.go
Outdated
Comment on lines
21
to
23
| Use: "eval", | ||
| Short: "Evaluate the combinations for a file at the given path", | ||
| Long: `Evaluate the combinations for a file at the given path. The file provided must be valid YAML. |
There was a problem hiding this comment.
Not a part of this commit, but the description for the completion command is not capitalized:
$ bin/combo help
Create combinations of kubernetes manifests
Usage:
combo [command]
Available Commands:
completion generate the autocompletion script for the specified shell
eval Evaluate the combinations for a file at the given path
help Help about any command
Flags:
-h, --help help for combo
Use "combo [command] --help" for more information about a command.bin/combo help=
There was a problem hiding this comment.
Would it be better to remove this command as it is auto-included in Cobra?
pkg/combination/combination.go
Outdated
Comment on lines
113
to
126
| var helper func(combo map[string]string, i int) | ||
| helper = func(combo map[string]string, i int) { | ||
| for _, val := range arrays[i] { | ||
| combo[replacements[i]] = val | ||
| if i == max { | ||
| // Append a copy of the map to the combos | ||
| comboCopy := map[string]string{} | ||
| copier.Copy(&comboCopy, &combo) | ||
| combos = append(combos, comboCopy) | ||
| } else { | ||
| helper(combo, i+1) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This should be it's own function.
njhale
reviewed
Oct 25, 2021
tylerslaton
force-pushed
the
initial-combo-cli
branch
from
cc5a247 to
3f3a582
Compare
tylerslaton
force-pushed
the
initial-combo-cli
branch
from
6874eaa to
710dcdc
Compare
tylerslaton
force-pushed
the
initial-combo-cli
branch
from
710dcdc to
14b36e3
Compare
tylerslaton
force-pushed
the
initial-combo-cli
branch
from
a46b3b7 to
96000da
Compare
… outlined in helm
|
#8 Has an update to the README as discussed earlier. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes PR #3
Adding the initial structure, logic, and general basis for the Combo CLI tool as defined by this repo's README.
Additions
Closes #1