✨ Bump to k8s.io/* v0.32.0-alpha.1 #2971
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
sbueringer
force-pushed
the
pr-bump-v0.32.0-alpha.1
branch
5 times, most recently
from
5ba1d56
to
df22cbc
Compare
|
I'll rebase once #2950 is merged Otherwise the current PR should be ready |
| @@ -24,6 +24,8 @@ source ${hack_dir}/common.sh | |||
| tmp_root=/tmp | |||
| kb_root_dir=$tmp_root/kubebuilder | |||
|
|
|||
| export GOTOOLCHAIN="go$(make go-version)" | |||
There was a problem hiding this comment.
@alvaroaleman @vincepri WDYT about this one? Seems like this could make us independent of the go version built into the CI image
There was a problem hiding this comment.
TIL about this. What I don't fully understand is how this interacts with the go version in the go.mod file? It would be good if we didn't override anything specified in the go.mod file, otherwise our CI may not be reflective of what actual end users see.
There was a problem hiding this comment.
Hm yeah this whole go toolchain feature is a bit complicated: https://go.dev/doc/toolchain
As far as I'm aware it doesn't overwrite what is in the go.mod file.
If I don't set this here and without changing the CI image we end up with this: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_controller-runtime/2971/pull-controller-runtime-apidiff/1844073887495622656
/home/prow/go/src/sigs.k8s.io/controller-runtime/hack/tools/bin/go-apidiff-v0.8.2 4cae9df --print-compatible
failed to get packages from new commit "HEAD" (79c1f765939e53ddc94401070922c37d797bfef6): err: exit status 1: stderr: go: go.mod requires go >= 1.23.0 (running go 1.22.8; GOTOOLCHAIN=local)
But I can also just keep it simple and bump the CI image to one that uses Go 1.23
There was a problem hiding this comment.
I guess this is fine, seems simpler for us and worst case we can change it later on
sbueringer
force-pushed
the
pr-bump-v0.32.0-alpha.1
branch
3 times, most recently
from
78bf5be
to
6253c7d
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-bump-v0.32.0-alpha.1
branch
from
6253c7d
to
6e9496d
Compare
| @@ -24,6 +24,8 @@ source ${hack_dir}/common.sh | |||
| tmp_root=/tmp | |||
| kb_root_dir=$tmp_root/kubebuilder | |||
|
|
|||
| export GOTOOLCHAIN="go$(make go-version)" | |||
There was a problem hiding this comment.
I guess this is fine, seems simpler for us and worst case we can change it later on
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3abaf1a827c74d450c5d56684dc5aebebd3ebbfb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com